search

fuelphp-storage / email

FuelPHP Framework - Email library
1 stars 1 forks source link

Return-Path header #4

Closed sagikazarmark closed 10 years ago

sagikazarmark commented 10 years ago

Return-Path is a header used to track bounce mails.

It has a config option in v1, but I would say,it is just a header, so should be removed and set as a header instead.

WanWizard commented 10 years ago

In a lot of situations you would always want to have a return path defined. If you remove it as a config option, you always have set it manually on every email instance you create.

It would be better if the config has a separate section on 'default values', which could be headers, or even recipients (for example: always add a bcc to every email).

sagikazarmark commented 10 years ago

I just did that ;)

Did not describe it, but I only wanted to remove it as a config item. But I am still not sure, since currently Return-Path is set to the from address if is not set by config. I wonder if it is good or not.

But I think it should be enough to add it in the config as a header, there is no need to automatically set it to the from address. Opinion?

WanWizard commented 10 years ago

in the RFC, if no Return-Path is defined, the from() address is used as return path. So it's not needed to set it, it's implicit.

sagikazarmark commented 10 years ago

Good. Then it can be removed as a config item. Can be set through config headers.