search

fukamachi / lack

Lack, the core of Clack
MIT License
155 stars 33 forks source link

Update on the session middleware and its use of a lock #62

Closed K1D77A closed 2 years ago

K1D77A commented 2 years ago

This is just a simple update on: https://github.com/fukamachi/lack/pull/58 Now uses :synchronized on SBCL and a lock on everything else. I have also added some doc strings. Thanks.

fukamachi commented 2 years ago

Do these changes make any improvements? In my experience, the :synchronized option makes all accesses to the hash table slow. Besides, the option is written as experimental. Are there any benefits in these implementation-specific changes?

mdbergmann commented 2 years ago

Is there a potential race condition?

K1D77A commented 2 years ago

Do these changes make any improvements? In my experience, the :synchronized option makes all accesses to the hash table slow. Besides, the option is written as experimental. Are there any benefits in these implementation-specific changes?

I spoke with svetlyak40wt and there probably isn't a point in doing this, especially with the #'equal and strings and keys so I will close.