search

fullstorydev / grpcui

An interactive web UI for gRPC, along the lines of postman
MIT License
5.25k stars 388 forks source link

use go:embed to bind data #156

Closed xwjdsh closed 1 year ago

xwjdsh commented 2 years ago

Simplify code.

jhump commented 2 years ago

@xwjdsh, thanks for the patch!

We intentionally support Go runtimes older than G 1.17. After 1.18 is GA (which should be in the coming month), maybe we can re-assess since, IIUC, the Go team will drop support for 1.16 at that point (based on their release policy).

In the meantime, let's leave this pull request open and consider merging it after that.

xwjdsh commented 2 years ago

@jhump actually the embed feature added in go1.16, I can change the version of the go.mod to go.1.16 if you want.

dragonsinth commented 1 year ago

This would need a rebase for conflict

xwjdsh commented 1 year ago

@dragonsinth Updated.

dragonsinth commented 1 year ago

https://github.com/fullstorydev/grpcui/pull/156/files#diff-288b5fde448529a95912cdc56f6eddfbb5baaff11e11bf53c3d1e3efed7c91b5R57

maybe // Add embedded resources bundled in standalone package TOC?

go1. 17 (released 2021-08-16) @jhump seems reasonable to support go 17, 18, 19 to me.

jhump commented 1 year ago

@jhump seems reasonable to support go 17, 18, 19 to me.

Sure, seems fine to me. I had commented almost a year ago, before 1.18 was released.