Add more options to AMQPConnectionConfiguration convenience inits

funcmike / rabbitmq-nio

A Swift implementation of AMQP 0.9.1 protocol: decoder + encoder and non-blocking client

Apache License 2.0

44 stars 8 forks source link

Add more options to AMQPConnectionConfiguration convenience inits #50

Open xtremekforever opened 3 days ago

xtremekforever commented 3 days ago

I was updating my swift-rabbitmq abstraction library (which depends on rabbitmq-nio) and ran into the problem of not being able to provide a custom timeout or connectionName to the .init methods that are used for convenience. So I added them as parameters to the 2 convenience inits and added some tests for them.

These options are defaulted to nil so that if they are not provided, the defaults are used.
Also cleaned up some whitespace in edited files.

xtremekforever commented 3 days ago

The build failure is something I also saw when using Swift 6.0.2 to run the tests. I switched to 5.10.1, but looks like it'll need to be addressed for the CI.

xtremekforever commented 1 day ago

@funcmike please review. My changes not only make the AMQPConnectionConfiguration.init methods more convenient with more parameters, but also improve the behavior of getting the URL parts converted to the correct formats with the percent encodings removed, on different versions of Swift.