fusionjs / fusion-core

Migrated to https://github.com/fusionjs/fusionjs
MIT License
630 stars 45 forks source link

Upgrade flow-bin to latest and fixes #356

Closed AlexMSmithCA closed 5 years ago

AlexMSmithCA commented 5 years ago

Upgrades flow-bin to v0.92.0 and resolves the following complaint:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/__tests__/sanitization.node.js:36:12

Cannot call null.toString because property toString is missing in null [1].

     33│   const userData = '<malicious data="" />';
     34│   const value = html`
     35│     <div>${userData}</div>
 [1] 36│     ${null.toString()}
     37│   `;
     38│   t.equals(typeof value, 'object');
     39│   t.equals(

Found 1 error
codecov[bot] commented 5 years ago

Codecov Report

Merging #356 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #356   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files          18      18           
  Lines         456     456           
  Branches       91      91           
======================================
  Hits          425     425           
  Misses         17      17           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65818f2...41c8d99. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #356 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #356   +/-   ##
======================================
  Coverage    93.2%   93.2%           
======================================
  Files          18      18           
  Lines         456     456           
  Branches       91      91           
======================================
  Hits          425     425           
  Misses         17      17           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65818f2...41c8d99. Read the comment docs.

AlexMSmithCA commented 5 years ago

!merge