withTranslations overwrites its child's context

fusionjs / fusion-plugin-i18n-react

Migrated to https://github.com/fusionjs/fusionjs

MIT License

4 stars 15 forks source link

withTranslations overwrites its child's context #176

Closed phou87 closed 5 years ago

phou87 commented 6 years ago

Due to this line, the component that withTranslations wraps loses its context. This is very harmful when used in conjunction with plugins such as fusion-plugin-rpc-redux-react (HOC's created by withRPCRedux rely on context.store to be defined, and it doesn't check for it, resulting in a delayed error).

rtsao commented 5 years ago

This was fixed in https://github.com/fusionjs/fusion-plugin-i18n-react/pull/175 and released in v1.1.1