Closed AlexMSmithCA closed 5 years ago
Found TODOs without GitHub issues: https://github.com/fusionjs/fusion-plugin-react-router/blob/47109efe8b8d1b688f7478b2dae945c27a943eb6/flow-typed/npm/prop-types_v15.x.x.js#L22 https://github.com/fusionjs/fusion-plugin-react-router/blob/47109efe8b8d1b688f7478b2dae945c27a943eb6/flow-typed/npm/prop-types_v15.x.x.js#L24
Merging #209 into master will increase coverage by
1.6%
. The diff coverage is90.9%
.
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
+ Coverage 77.65% 79.26% +1.6%
=========================================
Files 8 10 +2
Lines 188 217 +29
Branches 44 47 +3
=========================================
+ Hits 146 172 +26
- Misses 29 30 +1
- Partials 13 15 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/modules/Status.js | 90.9% <100%> (ø) |
:arrow_up: |
src/server.js | 100% <100%> (ø) |
|
src/browser.js | 100% <100%> (ø) |
|
src/plugin.js | 85% <100%> (ø) |
:arrow_up: |
src/modules/Redirect.js | 85.71% <100%> (+0.71%) |
:arrow_up: |
src/modules/ServerHistory.js | 45.71% <75%> (-1.35%) |
:arrow_down: |
src/modules/ServerRouter.js | 71.42% <75%> (-1.3%) |
:arrow_down: |
src/modules/Route.js | 75% <80%> (+2.77%) |
:arrow_up: |
src/modules/BrowserRouter.js | 95% <80%> (-5%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4cded7c...47109ef. Read the comment docs.
Merging #209 into master will increase coverage by
1.6%
. The diff coverage is90.9%
.
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
+ Coverage 77.65% 79.26% +1.6%
=========================================
Files 8 10 +2
Lines 188 217 +29
Branches 44 47 +3
=========================================
+ Hits 146 172 +26
- Misses 29 30 +1
- Partials 13 15 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/modules/Status.js | 90.9% <100%> (ø) |
:arrow_up: |
src/server.js | 100% <100%> (ø) |
|
src/browser.js | 100% <100%> (ø) |
|
src/plugin.js | 85% <100%> (ø) |
:arrow_up: |
src/modules/Redirect.js | 85.71% <100%> (+0.71%) |
:arrow_up: |
src/modules/ServerHistory.js | 45.71% <75%> (-1.35%) |
:arrow_down: |
src/modules/ServerRouter.js | 71.42% <75%> (-1.3%) |
:arrow_down: |
src/modules/Route.js | 75% <80%> (+2.77%) |
:arrow_up: |
src/modules/BrowserRouter.js | 95% <80%> (-5%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4cded7c...47109ef. Read the comment docs.
Merging #209 into master will increase coverage by
1.6%
. The diff coverage is90.9%
.
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
+ Coverage 77.65% 79.26% +1.6%
=========================================
Files 8 10 +2
Lines 188 217 +29
Branches 44 47 +3
=========================================
+ Hits 146 172 +26
- Misses 29 30 +1
- Partials 13 15 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/modules/Status.js | 90.9% <100%> (ø) |
:arrow_up: |
src/server.js | 100% <100%> (ø) |
|
src/browser.js | 100% <100%> (ø) |
|
src/plugin.js | 85% <100%> (ø) |
:arrow_up: |
src/modules/Redirect.js | 85.71% <100%> (+0.71%) |
:arrow_up: |
src/modules/ServerHistory.js | 45.71% <75%> (-1.35%) |
:arrow_down: |
src/modules/ServerRouter.js | 71.42% <75%> (-1.3%) |
:arrow_down: |
src/modules/Route.js | 75% <80%> (+2.77%) |
:arrow_up: |
src/modules/BrowserRouter.js | 95% <80%> (-5%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4cded7c...7998df7. Read the comment docs.
Improves overall coverage to 94%:
More importantly our exports are fully covered now.
Found TODOs without GitHub issues: https://github.com/fusionjs/fusion-plugin-react-router/blob/7998df722ba4ef3aa8df649ceb3e63818e112c2d/flow-typed/npm/prop-types_v15.x.x.js#L22 https://github.com/fusionjs/fusion-plugin-react-router/blob/7998df722ba4ef3aa8df649ceb3e63818e112c2d/flow-typed/npm/prop-types_v15.x.x.js#L24
A number of improvements to the static types in this package. Includes:
libdef
files for a number of dependencies (history, prop-types, react-router-dom, and tape-cup).libdef
to type globals.Resolves #208