futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
784 stars 49 forks source link

Grayjay on Galaxy Fold #34

Open brandon-futo opened 1 year ago

brandon-futo commented 1 year ago

User reports that the video gets the top/bottom of a video get cropped after unfolding the display (the display becomes wider) and it gets the left/right cropped after the display is folded (the display becomes narrower).

I imagine the video height is calculated once and is not correct after the screen's size changes.

brandon-futo commented 1 year ago

Starting with the device folded and then unfolding it unfolded

brandon-futo commented 1 year ago

Starting with the device unfolded and then folding it folded

EricsenSemedo commented 1 year ago

This is exactly what happens.

EricsenSemedo commented 1 year ago

The same sort of issue comes up when going from the inner screen to the outer screen when looking at the tabs bar. It either gets cut off going inner to outer screen or doesn't populate the tabs bar to take advantage of the extra screen space of the inner screen.

Zvonimir-FUTO commented 2 months ago

@brandon-futo This issue seems to be stale. Could you please confirm if this issue is still present in latest version of Grayjay?

brandon-futo commented 2 months ago

I made this issue in response to a support email received about a year ago and unfortunately I don't have a Galaxy Fold myself so I cannot test it. It seems like someone else made #1309 recently, so it's probably not fixed.

menturi commented 1 month ago

The same issue can be encountered if using an external screen. The attached screenshot is from using a 16:9 aspect ratio 1080p screen within Samsung Dex. The video is cropped at the top and bottom in the attached photo, though once the user enters fullscreen, the full video is shown without cropping.

Screenshot_20241001-203421_Grayjay - Copy