futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
799 stars 50 forks source link

End of video is cut off #36

Open GoodDays13 opened 1 year ago

GoodDays13 commented 1 year ago

This doesn't matter too much for most videos, but some videos have some sort of joke or cut-off thing like a cut scream right before the video ends. In the app, the video seems to stop a tiny bit before the video actually ends cutting off like half a second. here are 2 videos I've noticed this messes with: https://www.youtube.com/watch?v=5y1f01kPSVo https://www.youtube.com/watch?v=qpBKTGBCN0Y

JustCryen commented 1 year ago

Yup, basically every video is affected by this but the one that made me finally check if it's already been reported was this one. https://youtu.be/itQLBGQyTX8&t=1563

carloslockward commented 1 year ago

I have noticed this too

Bluscream commented 1 year ago

Happens to me aswell. I'm really curious on what is causing this. @koen-futo could you chime in on this potentially?

koen-futo commented 1 year ago

@Bluscream I have done some initial investigation but it doesn't look like a quick fix. ExoPlayer tells us the time bar for the video. For now it has less priority due to other higher priority issues.

Bluscream commented 1 year ago

@Bluscream I have done some initial investigation but it doesn't look like a quick fix. ExoPlayer tells us the time bar for the video. For now it has less priority due to other higher priority issues.

what happens if you just take exo's reported length+1s ? i would much rather have 1 second of blackscreen than 1 second missing at the end

koen-futo commented 1 year ago

That might work as a hackfix, ideally we spend some time figuring out the root cause and making a proper fix.

Bluscream commented 1 year ago

Well, you can provide this as a quick workaround, and take the meantime to properly and thouroughly find a real fix :brain:

jextrevor commented 1 year ago

Also seeing this issue with all YouTube videos. I don't see the issue happening with Odysee videos

jarredpickles87 commented 11 months ago

Still seeing videos getting cut off by about a second. Just wanted to update the report.

cesarila commented 11 months ago

Yep, same. It's especially noticeable on the "Trackmania 2020 World Records" channel, since they end their videos promptly at the finish line of the world record comparison.

Doc-4 commented 11 months ago

Still getting this, even on Louis's channel. Hope this gets fixed soon

FragileAgile commented 10 months ago

Have had this happening to me for a while now, finally mustered up the will to write a bug report but seems it's been happening to others, no change so far

PhilC813 commented 3 months ago

I was like Huh. MKBHD doesn't say "Peace" at the end of his videos anymore.

Titaniumtown commented 3 months ago

I was like Huh. MKBHD doesn't say "Peace" at the end of his videos anymore.

haha i forgot he said that since using grayjay lol

Bluscream commented 3 months ago

Missed opportunity to name the issue "End of video is cut o"

RehmatSChawla commented 3 months ago

I've seen this too, in almost every video I watch to the end I notice the last bit of the sentence being cut off.

DerangedWifi commented 2 months ago

Sorry, not sure if this is a dead issue, but Im having this issue on the latest version of grag for all videos. Yr plugin V205, Grayjay 264, Android Note 9.

skylarmt commented 1 month ago

Still happening, really annoying. I've had to open NewPipe for a couple videos that have the joke at the end.

Fairphone 5, CalyxOS 5.12.1, Android 14