Compatibility with bedrock-autoloader which loads plugins as must-use plugins

[gerwinjansen]

Fixes 2 problems:

• Couple of times plugins_url() . '/' . plugin_basename( dirname( __FILE__ ) ) . '<relative url here>' was used which resolved to /plugins/wp-youtube-lyte/<relative url here>. And that doesn't work when the plugin is loaded as /mu-plugins/wp-youtube-lyte.
• As workaround for issue roots/bedrock-autoloader#29, I explicitly made $lyteSettings declared as global.

[futtta]

first off; thanks @gerwinjansen, always happy to collaborate!

re. your changes, do you have it running like this on a (prefably) live site and all works as intended for you?

[gerwinjansen]

Glad to help!

My website repo is gerwinjansen/muziekpraktijkvivo-website and it runs on https://muziekpraktijkvivo.nl/. I created gerwinjansen/muziekpraktijkvivo-website#54 and deployed it to my acceptance environment. I manually patched the plugin in de webroot of my hosting provider. You can see it in action here: https://acceptatie.muziekpraktijkvivo.nl/geluidsfragmenten/afspelen/?fragment=112

My repo has a devcontainer, so you can try it yourself as well.

[gerwinjansen]

@futtta: my acceptance environment is still available for you. Can we conclude this PR?

[futtta]

sorry for the delay, looks OK indeed :-)

[gerwinjansen]

@futtta: Nice! When do you plan to release it?

[futtta]

I'm aiming for one of the next couple of weeks :)

On Fri, Sep 6, 2024 at 10:22 AM Gerwin Jansen @.***> wrote:

@futtta https://github.com/futtta: Nice! When do you plan to release it?

— Reply to this email directly, view it on GitHub https://github.com/futtta/wp-youtube-lyte/pull/40#issuecomment-2333513716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMIMPSI4VBFYGZHR3WRTLZVFQ5BAVCNFSM6AAAAABGPUJKUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGUYTGNZRGY . You are receiving this because you were mentioned.Message ID: @.***>

[futtta]

just pushed it out :)

[gerwinjansen]

Thanks, deployed and it works! Thanks a lot!