search

fvutils / pyucis

Python API to Unified Coverage Interoperability Standard (UCIS) Data
https://fvutils.github.io/pyucis
Apache License 2.0
21 stars 12 forks source link

Feature/read compressed xml #15

Closed eyck closed 2 years ago

eyck commented 2 years ago

This builds on top of the logging PR #14. It adds the ability to read gzip or lz4 compressed files if the respective Python modules are available

mballance commented 2 years ago

I like the feature addition, and like your approach of using the file magic number to check for required packages. Any thoughts on supporting output of compressed XML? Also, as a side note, your changes to implement logging (which are also good) appear to be combined with this PR. Not a problem in this case (two PRs that are both ready at the same time), but could be an issue with future PRs. My methodology is to create a new Git branch any time I anticipate creating a PR.

eyck commented 2 years ago

Also, as a side note, your changes to implement logging (which are also good) appear to be combined with this PR. Not a problem in this case (two PRs that are both ready at the same time), but could be an issue with future PRs. My methodology is to create a new Git branch any time I anticipate creating a PR.

That was a bit by accident since both originated from my master. I'm not that used to deal with PRs on github, we usually handle this using gitflow (internally to my company)

eyck commented 2 years ago

I like the feature addition, and like your approach of using the file magic number to check for required packages. Any thoughts on supporting output of compressed XML?

I think since it is possible to provide a filehandle to XmlFactory.write I would not add anything. The addition for read was mainly to make this feature available to the pyucis-viewer.