fwilliams / fml

FML (Francis' Machine-Learnin' Library) - A collection of utilities for machine learning tasks
MIT License
34 stars 6 forks source link

update logsumexp #5

Open edgarriba opened 4 years ago

edgarriba commented 4 years ago

hi @fwilliams,

in recent pytorch versions it has been introduced torch.logsumexp which I think that could be used to replace stabilized_log_sum_exp in your implementation of the sinkhorn algorithm.

found this throw: https://github.com/magicleap/SuperGluePretrainedNetwork/blob/master/models/superglue.py#L143-L172

fwilliams commented 4 years ago

Thanks for the pointer! I wrote this during a project in 2018 and didn't know this function was available. I'll update this in the next version of the library.