search

fwupd / firmware-dell

Missing firmware for Dell hardware
28 stars 4 forks source link

Optiplex 3080 "search" showing wrong latest version - remove extraneous leading zeros? #164

Closed pjwelsh closed 1 year ago

pjwelsh commented 1 year ago

LVFS version search page is showing "1.3.12" the latest: https://fwupd.org/lvfs/search?value=optiplex+3080

However, clicking the page link kinda has the correct version "00.2.17.1" showing. The issue may be in the odd leading zeros? They appear to be extraneous and may be causing the "issue". The official page does not have the leading zeros: https://www.dell.com/support/home/en-us/drivers/driversdetails?driverid=t1yjp&oscode=biosa&productcode=optiplex-3080-desktop

CragW commented 1 year ago

@hughsie is this a lvfs-website issue?

hughsie commented 1 year ago

@CragW this is caused by the "display version" override for the composite firmware (as opposed to component), which actually comes from the .inf file of all things. Originally (and perhaps ironically) Dell used the .inf file so that we would show the correct version string compared to the Dell website. It does seem that the leading zeros have been dropped from the Dell product pages -- and the "dell-bios" version format is being used instead. We also have a generic component[1] -- but that doesn't seem like it's being used by the peripheral team -- and they don't use .inf files either.

I actually think it might makes sense to drop the seemingly-magic-and-esoteric .inf parsing completely - as the original reason for it existing was that we only had quad and triplet version formats rather than vendor-specific newer formats like dell-bios.

@CragW if you agree with that assessment and solution, I'm happy to delete some code. @superm1 is there anything you wanted to add as a history lesson? No is a perfectly valid answer! :)

[1] https://lvfs.readthedocs.io/en/latest/metainfo.html#generic-components

superm1 commented 1 year ago

No nothing to add. I agree drop inf parsing.

hughsie commented 1 year ago

Okay, done. https://fwupd.org/lvfs/devices/com.dell.uefi10d19ee4.firmware now shows no leading zeros.

pjwelsh commented 1 year ago

Will the "search" part update later? Currently it shows a 1.3.12 version as newest now: https://fwupd.org/lvfs/search?value=optiplex+3080 Should be the "2.17.1" version.

CragW commented 1 year ago

@hughsie Agree with you for the change to inf parsing, thanks.

With regarding to the priority attribute for a composite device.. the dock BKC turned out is a rich mixture of 3 different docks and each packages has its own version. Perhaps pick one of them as the main representative rather a random subcomponent for now, and see how it goes with the clarity.

pjwelsh commented 1 year ago

Please re-open the ticket, the fundamental issue is still apparent - the wrong version is showing as latest when searched: https://fwupd.org/lvfs/search?value=optiplex+3080 Should show the "2.17.1" version and not the 1.3.12 version shown.

hughsie commented 1 year ago

Fixed in the latest LVFS deploy. Thanks all!