search

fyiorgnz / alaveteli

OIA/LGOIMA (Freedom of Information) request system: New Zealand fork of mysociety/alaveteli
https://fyi.org.nz/
Other
4 stars 3 forks source link

Merge sidekiq & develop branches with conditional Dockerfile #3

Open nigeljonez opened 5 years ago

nigeljonez commented 5 years ago

Will allow better Docker efficiencies (image size/etc) and make the codebase slightly easier to maintain.

olineham commented 5 years ago

We should do this anyway, but after that could also review whether sidekiq is still the best approach versus going back to cron. The sidekiq instance is sitting there using a lot of memory but is mostly idle.

nigeljonez commented 5 years ago

Implemented in 5f8b5ad6f94806a0974da9df4c0959cf23f8cee5

If you still want to look at going back to cron/cron-like most likely best to create another issue, that said, it does save resources as the environment start-up only has to run once vs every 5-10 minutes for some tasks.