fzaninotto / Faker

Faker is a PHP library that generates fake data for you
MIT License
26.79k stars 3.59k forks source link

Enhancement: Update vimeo/psalm #2072

Closed localheinz closed 4 years ago

localheinz commented 4 years ago

This PR

💁‍♂️ For reference, see https://github.com/vimeo/psalm/releases/tag/3.18.2.

localheinz commented 4 years ago

@pimjansen @fzaninotto

Rebased!

codecov-io commented 4 years ago

Codecov Report

Merging #2072 into next will decrease coverage by 0.80%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               next    #2072      +/-   ##
============================================
- Coverage     70.96%   70.16%   -0.81%     
  Complexity     1600     1600              
============================================
  Files           287      287              
  Lines          3864     3864              
============================================
- Hits           2742     2711      -31     
- Misses         1122     1153      +31     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/de_DE/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/he_IL/Address.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/ne_NP/Person.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/id_ID/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/cs_CZ/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/fi_FI/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/sr_Latn_RS/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/es_ES/Person.php 75.00% <0.00%> (-25.00%) 3.00% <0.00%> (ø%)
src/Faker/Provider/en_GB/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/es_AR/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0c661e...5f363a3. Read the comment docs.

pimjansen commented 4 years ago

@localheinz still got some conflicts on the baseline it seems

localheinz commented 4 years ago

@pimjansen

Rebased!

localheinz commented 4 years ago

Thank you, @pimjansen!