search

fzaninotto / screenshot-as-a-service

Website screenshot service powered by node.js and phantomjs
1.1k stars 243 forks source link

added Dockerfile #65

Open charford opened 9 years ago

fzaninotto commented 9 years ago

Could you add a line about this dockerfile in the README?

charford commented 9 years ago

@fzaninotto thanks for reviewing my pull request. I went ahead and made the requested changes, as well as added some docker info to readme.

A note about the .git directory:

The reason I remove it during the build process(Dockerfile), is because that directory is inside the docker image. It's not necessary to keep it inside of the docker image because those files will never be modified directly. Instead, you would make changes to the files in your regular git repo outside of the docker image(your local file system), and then rebuild the docker image.