search

ga-wdi-boston / js

Other
36 stars 212 forks source link

Use `Readline` for getting input from user. #39

Open gaand opened 8 years ago

gaand commented 8 years ago

See https://nodejs.org/api/readline.html

Refactor material that uses readline-sync to avoid promoting poor JavaScript habits.

This requires scaffolding the asynchronous nature of aquiring input using Readline.

jrhorn424 commented 7 years ago

I agree with this change, but I did not leave myself enough time to implement for this iteration.

raq929 commented 7 years ago

Not doing it for this iteration, but Antony's idea for this is to have a function that checks every x milliseconds to see if a boolean is true or false, and then exits when that boolean changes. Ask him for details.

gaand commented 7 years ago

Please see https://github.com/ga-wdi-boston/js/tree/readline

A lot of the code in the files should go on the solution branch, but not bin/guess.js most of that code should remain.

This branch partially addresses #51 #54 #56