ga-wdi-boston / orientation

Instructions for students beginning General Assembly's WDI program in Boston
Other
11 stars 198 forks source link

Dependencies for linter markdown to work. #184

Open gaand opened 8 years ago

gaand commented 8 years ago

For it to work in and out of atom:

All of these npm packages installed globally,

remark remark-cli remark-lint remark-preset-lint-consistent remark-preset-lint-recommended

Plus this in .remarkrc

{
+  "presets": [
+    "lint-consistent",
+    "lint-recommended"
+  ],
   "plugins": {
     "lint": {
gaand commented 8 years ago

This was working then stopped. I'm deeply confused but it seems related to AtomLinter/linter-markdown#115

jrhorn424 commented 7 years ago

This appears unresolved upstream. What should be our way forward? Disabling remark inside atom? disabling all linters inside atom and forcing everyone to run nag tasks?

raq929 commented 7 years ago

I think disabling linters inside atom would cause people to not lint at all, unless we implement something where you can't push unless the linter is clean, which I think would have other consequences.

On Wed, Jan 4, 2017 at 1:17 PM Jeffrey Horn notifications@github.com wrote:

This appears unresolved upstream. What should be our way forward? Disabling remark inside atom? disabling all linters inside atom and forcing everyone to run nag tasks?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ga-wdi-boston/orientation/issues/184#issuecomment-270444331, or mute the thread https://github.com/notifications/unsubscribe-auth/ANRw2LuquUJ-B1M1b2_uESWDRdYjqeqWks5rO-JCgaJpZM4Kn8kf .