ga-wdi-boston / ruby-object-self

Other
1 stars 141 forks source link

Method chainer example should not use the method name `.reverse!` or variable named `string` #32

Open MicFin opened 7 years ago

MicFin commented 7 years ago

.reverse! is also a string method so we can chain .reverse! and it continuously updates @content which hurts the example of not chaining unless we return self. It would be less confusing to not have an example that uses the same method name as a string method.

string variable name is confusing to work with.

https://github.com/ga-wdi-boston/ruby-object-self/blob/master/lib/method_chainer.rb