Open ahwagner opened 7 years ago
alternatively, it may be worthwhile to at least allow page size to be passed as a parameter to search_phenotype_association_sets
and other search methods.
@bwalsh, have you had to handle this issue in the past?
@ahwagner I did a quick check of the python code, nothing stood out as special case for page_size 0
+1 to changing the default to not 0 https://github.com/ga4gh/ga4gh-server/issues/1362
The search_phenotype_association_sets method (and presumably other methods that use the
ga4gh.client.protocol
module) automatically requests a page size of 0. This can lead to bad requests on servers not configured to explicitly handle page size 0 requests (e.g. http://rest.ensembl.org:8080/ga4gh/datasets/search).I suggest that we change this to a positive integer default, or omit it entirely and leave it to the server to specify the page size.