ga4gh / va-spec

An information model for representing variant annotations.
14 stars 2 forks source link

Naming conventions for multivalued attributes #97

Open mbrush opened 1 year ago

mbrush commented 1 year ago

Should we generally adhere to the convention that attributes that can be multivalued (i.e. cardinality of 0..m or 1..m) should have plural names where applicable (e.g. references not reference, aleternativeLabels not alternativeLabel, contributions not contribution)

Note that there are some cases where we cannot pluralize the name of a multivalued attribute, based on how we have chosen to name the field. e.g. specifiedBy, or isAbout, or performedBy.

To Do:

sivangbagri commented 6 months ago

@mbrush is this still open ?

larrybabb commented 1 week ago

@mbrush I think we all agree this is a good convention. do we need to keep this open or can we declare that when we identify any inconsistencies in this practice we will fix them?

Do you want to take the To Do on above (or have you already)? Please assign to yourself, unless you don't feel like you can take this on? Also, if you've done this work already, please go ahead an close this ticket.