Use Maven for the build process

[GoogleCodeExporter]

add maven feature to the project http://code.google.com/p/maven-gae-plugin/

(Reported by second.comet)

Original issue:
http://code.google.com/p/puzzlebazar/issues/detail?id=39

Original issue reported on code.google.com by philippe.beaudoin on 27 Mar 2010 at 5:54

[GoogleCodeExporter]

This seems like a popular request, let's do it for V0.1.

Original comment by philippe.beaudoin on 1 Apr 2010 at 6:36

• Added labels: Milestone-V1.0-1
• Removed labels: Milestone-V1.0-Release

[GoogleCodeExporter]

For V0.1 we will go with a Maven repository. See Issue 51.

It would be nice to consider a Maven build process for future releases, if 
anybody has 
experience with this, or can take the time to learn how to set it up, it would 
be a 
welcome addition.

Original comment by philippe.beaudoin on 7 Apr 2010 at 5:40

• Added labels: helpneeded

[GoogleCodeExporter]

Original comment by philippe.beaudoin on 9 Apr 2010 at 6:08

• Added labels: helpWelcome
• Removed labels: helpneeded

[GoogleCodeExporter]

Bumped to version 1.0.

Original comment by philippe.beaudoin on 16 Apr 2010 at 6:09

• Added labels: Milestone-V1.0-Release
• Removed labels: Milestone-V1.0-1

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

you've probably have come across this, dont know if this is covered by
maven-gae-plugin, this is maven-gwt-plugin:
http://mojo.codehaus.org/gwt-maven-plugin/

Original comment by jason.ve...@gmail.com on 22 Apr 2010 at 8:09

[GoogleCodeExporter]

Passing to Maven is not trivial (with GWT) and toke use much time. Once you use
Maven, you "need" (want) to use it in every project. It can be sometimes 
frustrating
for user that like to pimp his project (like me ;)) but it also very powerful,
managing magically all your dependencies.

We use Maven with GWT for more than 1 year. I can do it for you if you like. 
But you
will need to switch from the eclipse way of managing a project to the maven 
way. Do
you want it? (it's something like a one way ;))

Original comment by olivier....@free.fr on 28 Apr 2010 at 9:48

[GoogleCodeExporter]

Since I'm using GWTP two other projects that are not Maven-based, I think I 
will defer 
this issue a bit longer.

However for you, Maven fans, you can now find GWTP in a maven repository at:
 https://maven.gwt-platform.googlecode.com/hg/

Also see Issue 51.

Original comment by philippe.beaudoin on 28 May 2010 at 9:01

[GoogleCodeExporter]

Was just wondering if the maven repo was enough for you Maven's users ? What 
would be 
the benifit for you if GWTP go full maven considering that we will publish 
Maven build 
in the maven repository even if we don't ?

Original comment by goudreau...@gmail.com on 28 May 2010 at 10:25

[GoogleCodeExporter]

Full maven would help me stay on top of the active development in gwt-platform. 

Eclipse isn't part of my typical build system so I've been eagerly waiting for 
the 
maven support.  Maven makes it easier for me to build off the trunk so I can 
take 
advantage of more recent commits than the release schedule.

Is it possible for a nightly snapshot build to be in the maven repository?  

Original comment by josephalevin on 29 May 2010 at 12:02

[GoogleCodeExporter]

The build process without going full maven is easy enough to allow a nightly 
snapshot. 
It would be a pleasure for me to do that.

Original comment by goudreau...@gmail.com on 29 May 2010 at 12:58

[GoogleCodeExporter]

Speaking for myself, Maven repo is enough.  I don't really care how it's built.

Original comment by quinn.ro...@gmail.com on 29 May 2010 at 1:31

[GoogleCodeExporter]

Snapshot of 0.3 into maven repository :
http://code.google.com/p/gwt-platform/source/browse/?repo=maven

I'll try to give snapshots more often as we update the sources.

Original comment by goudreau...@gmail.com on 10 Jun 2010 at 4:35

[GoogleCodeExporter]

gonna like this !  awesome

Original comment by second.c...@gmail.com on 11 Jun 2010 at 3:26

[GoogleCodeExporter]

Implementation started

Original comment by nejakyus...@gmail.com on 13 Jul 2010 at 2:49

• Added labels: Milestone-V1.0-4

[GoogleCodeExporter]

Waiting for a review:
- HG clone with description and implementation 
http://code.google.com/r/nejakyusername-maven/
- Sources: https://nejakyusername-maven.googlecode.com/hg/
- Wiki: http://code.google.com/p/gwt-platform/wiki/BuildingWithMaven

Peter

Original comment by nejakyus...@gmail.com on 22 Jul 2010 at 11:43

[GoogleCodeExporter]

Great, thanks! I'm off to a conference for 2 weeks but will review this when 
I'm back. Meanwhile if another Maven expert wants to take a look, it would be 
very welcome.

Let's try to get this in 0.4.

Original comment by philippe.beaudoin on 22 Jul 2010 at 5:11

• Changed state: Started
• Added labels: needReview
• Removed labels: helpWelcome

[GoogleCodeExporter]

Checked it out, looks great! I'm pulling this right now.

Original comment by philippe.beaudoin on 23 Jul 2010 at 6:48

[GoogleCodeExporter]

Landed in r9800624b04

Thanks again, Peter!

Original comment by philippe.beaudoin on 23 Jul 2010 at 7:03

• Changed state: Done

[GoogleCodeExporter]

Hi, 
I am a fan of both maven and gwtp and I wanted to help with porting gwtp to 
maven.
I came a little late but nevertheless I've done a review to the pom.xml and and 
I have some thoughts I'd like to share and discuss (could someone point me to 
the right place to do so? is there a related thread? a rietveld setup? here?).

The most important thing right now is that the build fails due to the failing 
tests. I don't know if it is a known issue or not, but I didn't find a related 
reported issue for that.
Attached you can see the surefire report for the 4 failing tests 
(com.gwtplatform.mvp.client.PresenterWidgetImplTest.txt) and 1 error 
(com.gwtplatform.testing.TestScope.txt). 
Regarding the error, I've fixed it in 
[http://code.google.com/r/jgonian-maven2/source/detail?r=6dd86b706e 
6dd86b706e]. 
Regarding the failing tests I didn't go deep but I've found that they will only 
fail if assertions are enabled (i.e. add -ea VM parameter).

Finally, I've created a clone of nejakyusername-maven clone and did some 
changes. Please review them and let me know where should I follow-up with my 
remarks. Please, note that I haven't used mercurial before and I can't be sure 
I did everything right.

- Yannis

Original comment by jgon...@gmail.com on 25 Jul 2010 at 10:21

Attachments:

• com.gwtplatform.mvp.client.PresenterWidgetImplTest.txt
• com.gwtplatform.testing.TestScope.txt

[GoogleCodeExporter]

Great work nejak, philippe and jgonian - thanks and kudos to everyone!

Original comment by demisone@gmail.com on 25 Jul 2010 at 10:30

[GoogleCodeExporter]

I forgot to post the link for my changes:
http://code.google.com/r/jgonian-maven2/source/list

Original comment by jgon...@gmail.com on 25 Jul 2010 at 10:32

[GoogleCodeExporter]

Yannis, thank you for a review and fixes. I'll look to the changes later and if 
it will be ok I will merge the changes. Firstly few comments from my side:
- changes from nejakyusername-maven clone were already merged into trunk so you 
can create clone directly from the trunk
- you can also leave your comments here 
http://code.google.com/p/gwt-platform/wiki/BuildingWithMaven

Thank you again Yannis!

Peter

Original comment by nejakyus...@gmail.com on 25 Jul 2010 at 10:37

[GoogleCodeExporter]

Original comment by philippe.beaudoin on 10 Sep 2010 at 12:39

• Removed labels: needReview