search

gabrial11392 / gwt-platform

Automatically exported from code.google.com/p/gwt-platform
0 stars 0 forks source link

Make onReveal, onHide and onReset protected #40

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Right now, the onReveal, onHide and onReset are public. They should really be 
protected with a public entry point, like onBind and onUnbind.

onReset already has an entry point (reset), there should be a way to make 
onReset protected. 

Doing this will probably involve casting elements added to the activeChildren 
list to PresenterWidgetImpl, but this is better than exposing too much stuff.

Original issue reported on code.google.com by philippe.beaudoin on 31 Mar 2010 at 6:06

GoogleCodeExporter commented 9 years ago 
Done. Much less stuff is exposed in Presenter and PresenterWidget. There is a 
bit of 
casting here and there, but I'm comfortable with this, as it means a simpler 
interface for the users.

Original comment by philippe.beaudoin on 2 Apr 2010 at 9:39

GoogleCodeExporter commented 9 years ago

Original comment by philippe.beaudoin on 2 Apr 2010 at 9:40