search

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
713 stars 207 forks source link

CodeClimate.json is missing description property #203

Open jnovick opened 5 years ago

jnovick commented 5 years ago

As per the official documentation, there should be a description field, but there isn't. Looking at the code, the same value set for check_name could be used for description. check_name is not required for Gitlab according to the docs.

mlapaglia commented 5 years ago

Here's a fix https://github.com/gabrie-allaigre/sonar-gitlab-plugin/pull/208

In the mean time, you can manually replace the check_name with description yourself in the build file I used: powershell -Command "(gc codeclimate.json) -replace 'check_name', 'description' | Out-File codeclimate.json" on windows

jnovick commented 5 years ago

The linux (bash) equivalent that I used sed -i s/check_name/description/ codeclimate.json

jnovick commented 4 years ago

Looks like this was taken care of here: https://github.com/gabrie-allaigre/sonar-gitlab-plugin/pull/208

I think this issue should be closed, right?