search

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
713 stars 207 forks source link

Map Sonar message to CodeClimate description instead of check_name #217

Closed Sidnioulz closed 5 years ago

Sidnioulz commented 5 years ago

Hi,

GitLab rather explicitly state that they ignore most of a Code Climate report, and they only use the four following fields: fingerprint, location.path, location.lines.begin and location.description.

To me it feels that the description is what should be used to put issue.getMessage(). Moreover, the Code Climate doc shows examples of check_name that really are the name of the rule being used to produce an output, and not a human-readable description of how this rule, in this specific instance, doesn't work.

So, since GitLab won't show check_name, and since description is a better match for a Sonar issue message than check_name, I'm submitting this request.

Sidnioulz commented 5 years ago

I have missed https://github.com/gabrie-allaigre/sonar-gitlab-plugin/pull/208 which proposes the same change, but with better handling of tests.