search

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
713 stars 207 forks source link

Multiple project.settings (with commit status) in a single pipeline #228

Open sseypt opened 5 years ago

sseypt commented 5 years ago

Hi.

We are using multiple sonar-project.properties in different jobs in a single pipeline. So far so good 👍 That way we can have certain modules analyzed more strict that others.

We now came across an issue with the static status name - they are overwriting each others:

grafik

Reason for this is private static final String COMMIT_CONTEXT = "sonarqube"

https://github.com/gabrie-allaigre/sonar-gitlab-plugin/blob/8ca448142890e0246c832f83aab4da340743a0e9/src/main/java/com/talanlabs/sonar/plugins/gitlab/GitLabApiV3Wrapper.java#L211

https://github.com/gabrie-allaigre/sonar-gitlab-plugin/search?q=COMMIT_CONTEXT&unscoped_q=COMMIT_CONTEXT

We'd like to stick to gitlab's commit status and I'm wondering if there's another way or is it possible to make it configurable?

Before I could come up with a pull request, I'd like to discuss it first 😄

Best regards, Steve

gabrie-allaigre commented 5 years ago

Hi, Yes, you propose PR. Thanks