search

gabrielbull / react-desktop

React UI Components for macOS High Sierra and Windows 10
http://reactdesktop.js.org
MIT License
9.52k stars 462 forks source link

Use index.js for components #110

Closed alacroix closed 6 years ago

alacroix commented 6 years ago

Hey!

I was looking for desktop interface and I found your project. This projects rocks!

I wanted to contribute so I looked into the Projects tab and found this first task: "Rename all components files that are inside of a directory by the same name to index. (I.E. pane/pane.js -> Pane/index.jsx)".

I didn't use the .jsx extension according to this issue discussion.

I split the tasks into 2 parts of 4 commits each for readability.

First, the "main" components which are just under the OS directory (like src/box/macOs/box.js) and then the "sub" components (like src/listView/macOs/footer/footer.js).

The first part wasn't specified in the task so I can drop it if you disapprove. My point was that we got the name already in the path so no need to repeat itself again.

I've got some free time right now so I'll try to do others tasks.

gabrielbull commented 6 years ago

Looks good. I will merge tomorrow when I get some time. And I agree about the jsx extension being superfluous.

Merci, c'est très apprécier. 🎉

alacroix commented 6 years ago

@gabrielbull Glad I helped :) I will take as next task "Capitalize file names for components (window.js -> Window.js)". And after, maybe Jest as tests or switch to better style management like Styled-components or Emotion