search

gabrielbull / react-desktop

React UI Components for macOS High Sierra and Windows 10
http://reactdesktop.js.org
MIT License
9.52k stars 462 forks source link

Unable to style label generated by TextInput #77

Closed bushidocodes closed 7 years ago

bushidocodes commented 7 years ago

Firstly, thanks so much for you work on this! I'm quite enthused to have such an easy experience building a Windows 10 themed Electron app.

My issue is that when my app is using the the dark theme, I can't style the labels associated with the components. Based on your code examples, I was expecting the default behavior of these labels to be that they dynamically determine the color based on the theme, similar to what you suggest for the components. My app is currently pulling UI settings from redux, and I'd like to be able to let the user toggle between light and dark themes (with the text reacting to the props appropriately). I'm likely going to strip out the labels and replace them with components as a workaround, but if I'm missing something.

image

gabrielbull commented 7 years ago

Hi, thanks for submitting the issue. The label should now change color based on theme for version 0.2.16. On top of that, you now have the ability to specify a color using the labelColor property and overwrite any label style using the labelStyle property. All info can be found in the docs. Cheers and happy new year!