search

gabstv / go-monero

A Monero RPC Wallet client implementation written in Go (Golang)
MIT License
59 stars 22 forks source link

Some naming conventions #2

Closed sammy007 closed 6 years ago

sammy007 commented 6 years ago

It would be nice to rename current Getheight, Getaddress to GetHeight, GetAddress.

sammy007 commented 6 years ago

Getbalance also.

gabstv commented 6 years ago

Initially I was converting the names like:
getbalance -> Getbalance
start_mining -> StartMining

But I admit that the first RPC functions look weird. It looks like the RPC devs were not following a convention before, but then they decided to add the undercore on the newer methods (and kept the older functions unchanged to avoid breaking implementations).