eric-hunt
commented
2 months ago Thank you for the input! I have made the changed you suggested and renamed the file.
I had to change what you suggested for handling the variant argument a little bit because the switch() for the palette was throwing an error if the variant argument didn't explicitly return "base". Also I had to change how I programmatically named the files and theme as I was relying on is.null() with the variant argument.
I also went ahead and removed those ill-escaped scss lines from the embark.R template as well so they didn't live on kicking around in that theme.
I re-sourced make.R and it seems like everything worked, so if those changed I made to your suggestions look okay to you, I think this is good to go.
Hey @gadenbuie, Here's another pull request for the Rosé Pine themes. There are two dark variants (the base theme, and "Moon") and one light variant ("Dawn"). I kind of copied the way the Material themes are built for this one to recursively go through the variants and update the palette accordingly.
Also, I updated a link for the Embark theme in the palette list file because I realized after deleting the merged branch, the reference now pointed to nowhere.