gadenbuie / rsthemes

🔮 Full RStudio IDE and Syntax Themes
https://www.garrickadenbuie.com/project/rsthemes/
Other
602 stars 45 forks source link

some themes have too much padding in file tabs #77

Closed tjmahr closed 3 years ago

tjmahr commented 3 years ago

Here is a11y-dark. This looks correct:

image

Here is Flat White. The tabs with the file names for open files have a lot of padding around them.

image

This padding also affects:

I used install_rsthemes() and try_rsthemes() on all 98 it was these four that had the tall tab issue.

- Session info  --------------------------------------------
 hash: national park, person: blond hair, waving hand: medium-dark skin tone

 setting  value
 version  R version 4.1.2 (2021-11-01)
 os       Windows 10 x64 (build 22000)
 system   x86_64, mingw32
 ui       RStudio
 language (EN)
 collate  English_United States.1252
 ctype    English_United States.1252
 tz       America/Chicago
 date     2021-11-15
 rstudio  2021.09.0-preview+341 Ghost Orchid (desktop)
 pandoc   2.14.0.3 @ C:/Program Files/RStudio/bin/pandoc/ (via rmarkdown)

- Packages -------------------------------------------------
 package        * version date (UTC) lib source
 abind            1.4-5   2016-07-21 [1] CRAN (R 4.1.0)
 arrayhelpers     1.1-0   2020-02-04 [1] CRAN (R 4.1.0)
 assertthat       0.2.1   2019-03-21 [1] CRAN (R 4.1.0)
 backports        1.3.0   2021-10-27 [1] CRAN (R 4.1.1)
 cellranger       1.1.0   2016-07-27 [1] CRAN (R 4.1.0)
 checkmate        2.0.0   2020-02-06 [1] CRAN (R 4.1.0)
 cli              3.1.0   2021-10-27 [1] CRAN (R 4.1.1)
 coda             0.19-4  2020-09-30 [1] CRAN (R 4.1.0)
 colorspace       2.0-2   2021-06-24 [1] CRAN (R 4.1.0)
 crayon           1.4.2   2021-10-29 [1] CRAN (R 4.1.1)
 DBI              1.1.1   2021-01-15 [1] CRAN (R 4.1.0)
 digest           0.6.28  2021-09-23 [1] CRAN (R 4.1.1)
 distributional   0.2.2   2021-02-02 [1] CRAN (R 4.1.0)
 dplyr            1.0.7   2021-06-18 [1] CRAN (R 4.1.0)
 ellipsis         0.3.2   2021-04-29 [1] CRAN (R 4.1.0)
 evaluate         0.14    2019-05-28 [1] CRAN (R 4.1.0)
 fansi            0.5.0   2021-05-25 [1] CRAN (R 4.1.0)
 farver           2.1.0   2021-02-28 [1] CRAN (R 4.1.0)
 fastmap          1.1.0   2021-01-25 [1] CRAN (R 4.1.0)
 generics         0.1.1   2021-10-25 [1] CRAN (R 4.1.1)
 ggdist           3.0.0   2021-07-19 [1] CRAN (R 4.1.0)
 ggplot2          3.3.5   2021-06-25 [1] CRAN (R 4.1.0)
 glue             1.4.2   2020-08-27 [1] CRAN (R 4.1.1)
 gtable           0.3.0   2019-03-25 [1] CRAN (R 4.1.0)
 htmltools        0.5.2   2021-08-25 [1] CRAN (R 4.1.1)
 janitor          2.1.0   2021-01-05 [1] CRAN (R 4.1.0)
 knitr            1.36    2021-09-29 [1] CRAN (R 4.1.1)
 lattice          0.20-45 2021-09-22 [2] CRAN (R 4.1.2)
 lifecycle        1.0.1   2021-09-24 [1] CRAN (R 4.1.1)
 lubridate        1.8.0   2021-10-07 [1] CRAN (R 4.1.1)
 magrittr         2.0.1   2020-11-17 [1] CRAN (R 4.1.0)
 munsell          0.5.0   2018-06-12 [1] CRAN (R 4.1.0)
 pillar           1.6.4   2021-10-18 [1] CRAN (R 4.1.1)
 pkgconfig        2.0.3   2019-09-22 [1] CRAN (R 4.1.0)
 posterior        1.1.0   2021-09-09 [1] CRAN (R 4.1.1)
 purrr            0.3.4   2020-04-17 [1] CRAN (R 4.1.0)
 R6               2.5.1   2021-08-19 [1] CRAN (R 4.1.1)
 Rcpp             1.0.7   2021-07-07 [1] CRAN (R 4.1.0)
 readxl           1.3.1   2019-03-13 [1] CRAN (R 4.1.0)
 rlang            0.4.12  2021-10-18 [1] CRAN (R 4.1.1)
 rmarkdown        2.11    2021-09-14 [1] CRAN (R 4.1.1)
 rsconnect        0.8.24  2021-08-05 [1] CRAN (R 4.1.0)
 rsthemes         0.3.0   2021-11-12 [1] https://gadenbuie.r-universe.dev (R 4.1.2)
 rstudioapi       0.13    2020-11-12 [1] CRAN (R 4.1.0)
 scales           1.1.1   2020-05-11 [1] CRAN (R 4.1.0)
 sessioninfo      1.2.1   2021-11-02 [1] CRAN (R 4.1.2)
 snakecase        0.11.0  2019-05-25 [1] CRAN (R 4.1.0)
 spelling         2.2     2020-10-18 [1] CRAN (R 4.1.0)
 stringi          1.7.5   2021-10-04 [1] CRAN (R 4.1.1)
 stringr          1.4.0   2019-02-10 [1] CRAN (R 4.1.0)
 svUnit           1.0.6   2021-04-19 [1] CRAN (R 4.1.0)
 tensorA          0.36.2  2020-11-19 [1] CRAN (R 4.1.0)
 tibble           3.1.5   2021-09-30 [1] CRAN (R 4.1.1)
 tidybayes        3.0.1   2021-08-22 [1] CRAN (R 4.1.1)
 tidyr            1.1.4   2021-09-27 [1] CRAN (R 4.1.1)
 tidyselect       1.1.1   2021-04-30 [1] CRAN (R 4.1.0)
 utf8             1.2.2   2021-07-24 [1] CRAN (R 4.1.0)
 vctrs            0.3.8   2021-04-29 [1] CRAN (R 4.1.0)
 xfun             0.27    2021-10-18 [1] CRAN (R 4.1.1)
 yaml             2.2.1   2020-02-01 [1] CRAN (R 4.1.0)

 [1] C:/Users/trist/Documents/R/win-library/4.1
 [2] C:/Program Files/R/R-4.1.2/library

------------------------------------------------------------
tjmahr commented 3 years ago

It also affects the four Material themes. I just didn't notice when I was previewing them.

gadenbuie commented 3 years ago

Yup this is by design (and quite a few hours hunting CSS classes). Those themes are all ports of VSCode themes, which features larger tab areas. I admit I didn't have a strong preference for the larger tabs when I first added them to rsthemes, but now RStudio's tiny little default tab size is just too uncomfortably cramped for me.

Here's a screenshot of Night Owl in VSCode for reference.

image

(And are you really changing away from Yule right before the holiday season? 😆)

tjmahr commented 3 years ago

Ah, that makes sense... that it's more than a color scheme if we are going to port from VSCode.

And ha, I just wanted to see the new themes. I'm back in Yule land.

gadenbuie commented 3 years ago

A man in a ridiculous holiday sweater in front of a Christmas tree. He gestures to show off his sweater, which features a reindeer head centered in a wreath in the middle of his chest. The body and arms of the sweater are made of long white threads and the whole thing is very over the top.