Closed werkstattcodes closed 2 years ago
One addition: the theme(s) seemed to work fine after updating R/RStudio. Only after I wanted to change a theme, the problem started to occurr. Right after updating R/RStudio, it was still displayed correctly.
Can you confirm that you also ran rsthemes::install_themes()
after installing the latest version of rsthemes?
Many thanks for your swift reaction. Yes, just installed the package again (this time from Github), and subsequently I installed the themes. The issue remains.
Okay, that's unfortunate. Have you also restarted RStudio after reinstalling the themes?
Yes. Multiple times. Also R and the computer.
Ok, I am starting to wonder whether this is an issue of RStudio, and not related to rsthemes. E.g. if I use another dark theme, not from rstheme, the file pane looks somewhat odd. As far as I can remember, the file names were previously not blue.
I'm not sure... I can't reproduce this issue on Mac with that version of RStudio. One more drastic thing to try would be to uninstall the themes from rsthemes before re-installing them. You can do this on a theme-by-theme basis
rstudioapi::removeTheme("Night Owl {rsthemes}")
rsthemes::install_themes()
Or you can do it all at once with
rsthemes::remove_themes()
rsthemes::install_themes()
Another diagnostic would be to make sure that RStudio's using the latest copy of the theme. Sometimes it caches the theme files and uses an older version for a while. Restarting RStudio and your computer should have fixed that, but it's worth trying. Here's a screen grab about how to do that...
https://user-images.githubusercontent.com/5420529/167451987-142a2132-b7d4-4244-974b-d4f9466f6d12.mp4
Many thanks for the very detailed and helpful answer. I can confirm that I am on rsthemes 0.3.1.
As some further info: Here a screenshot of the wrongly colored tab-bar and the css entry when using the a11-y-dark theme.
I am not sufficiently familiar with these things, but I strongly suspect by now that it has something to do with RStudio and not rsthemes. There were a few seemingly similar entries on the RStudio Community page recently (here my entry), but so far no solution came up.
Feel free to close the issue. If you keep it open, I'll post the solution once it transpired. Many thanks again!
I'm trying to collect more information in https://github.com/rstudio/rstudio/issues/11176 -- @werkstattcodes, if you can share some more detail, it would be helpful (as I thus far cannot reproduce locally).
Here's what I get when using the a11y-dark theme from rsthemes
.rs.api.getThemeInfo()
$editor [1] "a11y-dark {rsthemes}"
$global [1] "Modern"
$dark [1] FALSE
$foreground [1] "rgb(254, 254, 254)"
$background [1] "rgb(43, 43, 43)"
Here's what I get when using the **Express theme** (dark, which comes with RStudio).
$editor [1] "Express"
$global [1] "Modern"
$dark [1] FALSE
$foreground [1] "rgb(221, 221, 221)"
$background [1] "rgb(35, 35, 35)"
Thanks for the extra details @werkstattcodes. I think it'd be most helpful if you could answer @kevinushey's question in this comment over in the rstudio issue. (It'd be best to answer there.) Thanks!
I think this has been resolved upstream but please let me know if not.
Many thanks for this very helpful package.
I just updated to R 4.2. (patched version) and the latest RStudio (2022.02.2 Build 485). Subsequently, I also installed RTools 4.2. link and reinstalled your package.
However, there is now an issue when e.g. using the theme Night Owl. Elements in RStudio are not properly darkened. Any idea what could resolve the issue? Many thanks!