Mispelled variable that breaks whitelisting when updating.

gaenserich / hostsblock

an ad- and malware-blocking script for Linux

https://github.com/gaenserich/hostsblock

225 stars 28 forks source link

Mispelled variable that breaks whitelisting when updating. #36

Closed eduardoeae closed 9 years ago

eduardoeae commented 9 years ago

In hostsblock.sh and hostsblock-common.sh there is a variable misspelled 4 times. "whilelist" Should be "whitelist" (L -> T). This causes white-listing not applying when updating hosts.

mkoskar commented 9 years ago

I generally as far as bash best practices goes always set set -eu depending on error handling code even -E might be of interest. -u should catch errors like above (btw. I didn't check the source to confirm it).

gaenserich commented 9 years ago

@mkoskar thanks for the tip! fixed: 6f0f04a34526313b581028c7f1ecb6c13554c3da