gaenserich / hostsblock

an ad- and malware-blocking script for Linux
https://github.com/gaenserich/hostsblock
225 stars 28 forks source link

Add adaway source list #51

Closed pickfire closed 8 years ago

pickfire commented 8 years ago

I saw this adaway source file at https://github.com/StevenBlack/hosts/blob/master/data/adaway.org/update.info, I hope that it can be a default as I found the adaway sources list nice.

Sadi58 commented 8 years ago

I've added it the adaway blocklist at http://adaway.org/hosts.tx to my .conf file as well as the following ;-) https://raw.githubusercontent.com/Sadi58/hostsblock/master/indicator/hosts.txt But I wonder why this file at github always appears "updated" although I haven't even viewed it :)

pickfire commented 8 years ago

But I wonder why this file at github always appears "updated" although I haven't even viewed it :)

What do you mean?

Sadi58 commented 8 years ago

I have this list of undesirable domains which I'd like to share and use as part of the hostsblock lists in the .conf file, and I thought it could be a good idea to maintain it at github. But every time hostsblock checks it if has been updated, it is detected as "updated" (although no change has been made in the list) probably resulting in an unnecessary process of downloading and including the same list again.

pickfire commented 8 years ago

@Sadi58 Probably it didn't do a diff.

Sadi58 commented 8 years ago

Strange; why shouldn't it do a diff consistently for this list and not others? I wonder if it has something to do with the extremely long URL and the resulting file names in the cache, which hostsblock apparently had to abbreviate like this: "https:..raw.githubusercontent.com.Sadi58.hostsblock.master.indicator.hosts.txt"

pickfire commented 8 years ago

@Sadi58 It seems like it is weird, I think I need to create a separate issue for this after I had confirmed it.

Sadi58 commented 8 years ago

@pickfire OK, thanks.