search

galacean / effects-runtime

It can load and render cool animation effects
https://www.galacean.com/effects/
MIT License
367 stars 11 forks source link

feat: item active setting #716

Closed wumaolinmaoan closed 3 weeks ago

wumaolinmaoan commented 3 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

[!WARNING]

Rate limit exceeded

@wumaolinmaoan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between 8bef28d88dcc49627b4d5690010cfa9f9e5b0126 and cf2f7f6064bd23fa6cc27ef583de9052c35a9075.

Walkthrough

The pull request introduces significant changes to the handling of item visibility and activation across multiple classes in the effects-core package. Key modifications include renaming methods related to visibility management, such as changing showItems to onEnable and hideItems to onDisable. The visibility checks have been replaced with activity checks, using methods like setActive instead of setVisible. These changes affect the CompositionComponent, VFXItem, and related classes, streamlining how visibility and activity states are managed throughout the system.

Changes

File Change Summary
packages/effects-core/src/comp-vfx-item.ts Renamed showItems to onEnable and hideItems to onDisable. Updated visibility management to use setActive(true/false) instead of setVisible(true/false).
packages/effects-core/src/components/component.ts Updated isActiveAndEnabled to use this.item.isActive() instead of this.item.getVisible(). Adjusted setVFXItem logic to reflect the new active state checks.
packages/effects-core/src/composition.ts Renamed setVisible to setActive, updating method calls accordingly. Enhanced comments for clarity.
packages/effects-core/src/plugins/timeline/playables/activation-mixer-playable.ts Removed showRendererComponents and hideRendererComponents. Simplified processFrame to directly set boundItem active state based on input detection.
packages/effects-core/src/plugins/timeline/playables/sub-composition-mixer-playable.ts Replaced calls to compositionComponent.showItems() and hideItems() with direct setActive(true/false) calls on compositionComponent.item.
packages/effects-core/src/vfx-item.ts Renamed visible to active, changing access modifier to private. Updated methods to reflect the new active state management (getVisible to isActive, etc.).
web-packages/imgui-demo/src/object-inspectors/vfx-item-inspector.ts Updated visibility checks from activeObject.getVisible() to activeObject.isActive(), aligning GUI interactions with the new method names.
web-packages/test/unit/src/effects-core/composition/composition.spec.ts Changed test assertions from getVisible() to isActive() for item visibility checks, reflecting the updated logic.

Possibly related PRs

Suggested reviewers

🐇 In the realm of effects, we hop and play,
With items active, come what may!
From visible states to active calls,
Our changes echo through the halls.
So let’s celebrate, with joy and cheer,
For a vibrant world, we hold so dear! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.