coderabbitai[bot]
commented
1 month ago [!WARNING]
Rate limit exceeded
@luzhuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 54 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.📥 Commits
Files that changed from the base of the PR and between e4b4c2a7c53900d2ae845a3b5f1ade4976351e2a and ad15b18966019b26df7469648f5a2a848cebc045.
Walkthrough
The changes in this pull request enhance the Animator class and its related components within the animation system. Key modifications include the introduction of new internal methods for calculating animation clip timings in the AnimatorState class, updates to transition logic in Animator and AnimatorStateTransitionCollection, and improvements to the test suite for the Animator class. These changes refine the handling of animation states and transitions, ensuring more robust and clear functionality.
Changes
| File Path | Change Summary |
|---|---|
packages/core/src/animation/Animator.ts |
- Adjusted transition logic to use a new transitionCollection parameter.- Added _deactivateTriggeredParameters method for managing triggered parameters.- Renamed isForwards to isForward in multiple methods. |
packages/core/src/animation/AnimatorState.ts |
- Added two new internal methods: _getClipActualStartTime and _getClipActualEndTime for calculating clip timing.- Modified clearTransitions to clear transition collection directly.- Updated return types for clipStartTime and clipEndTime. |
packages/core/src/animation/AnimatorStateTransitionCollection.ts |
- Made _transitions publicly accessible as transitions.- Introduced new properties: noExitTimeCount, needReset, and currentTransitionIndex.- Refactored add, remove, and clear methods for new transition management logic.- Added several new methods for transition checks. |
tests/src/core/Animator.test.ts |
- Enhanced test suite with new tests for animator functionality, including parameter handling and transition behavior. - Added cleanup in afterEach for better state management between tests. |
packages/core/src/animation/internal/AnimatorStatePlayData.ts |
- Renamed isForwards property to isForward and updated related methods.- Removed initialization of currentTransitionIndex and added a reset for _needReset. |
packages/core/src/animation/internal/AnimatorLayerData.ts |
- Removed anyTransitionIndex property, simplifying the class structure. |
packages/core/src/animation/AnimatorStateMachine.ts |
- Updated accessors for entryTransitions and anyStateTransitions to return the transitions property instead of the _transitions property. |
Possibly related PRs
- #2359: This PR modifies the
AnimatorStateclass to enhance transition management, which is directly related to the changes in the main PR that also updates transition handling in theAnimatorStateclass. - #2377: This PR introduces support for fixed duration in transitions, which aligns with the main PR's focus on improving transition management and timing in the
AnimatorStateclass. - #2390: This PR adds properties to
AnimatorLayerData, which may indirectly relate to the overall structure and management of animation states and transitions discussed in the main PR.
Suggested labels
enhancement
Suggested reviewers
- GuoLei1990
🐇 In the world of animation, we leap and bound,
With fixed times in place, our transitions are sound.
No more variable woes, just smooth, steady flow,
Animator's magic, watch our movements glow!
Hops and skips, in perfect sync,
With each little change, we make the world blink! ✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor