search

galaxy-genome-annotation / docker-galaxy-genome-annotation

:whale: Galaxy Docker Image with Tools for Genome Annotation
MIT License
11 stars 9 forks source link

Workflow for trinotate #5

Open Eduardo-Alves opened 8 years ago

Eduardo-Alves commented 8 years ago

https://trinotate.github.io

Eduardo-Alves commented 8 years ago

signalp 4.0 requires a license. we may have to stick with 3.0 which is wrapped already https://toolshed.g2.bx.psu.edu/repository/browse_repository?id=292389a45f1a238a I will test loading the db with results from signalp 3.0 today and see if it works.

bgruening commented 8 years ago

True, this was an issue :(

lecorguille commented 8 years ago

@bgruening Can we imagine pushing those developments under IUC repo and blacklist them https://github.com/galaxyproject/tools-iuc/blob/master/.tt_blacklist?

bgruening commented 8 years ago

The new signalp wrappers? Or what do you mean?

Eduardo-Alves commented 8 years ago

I checked the wrapper and it requires users to install the dependencies themselves. is this the approach we should take with software that requires license?

http://toolshed.g2.bx.psu.edu/view/peterjc/tmhmm_and_signalp

"First install those command line tools you wish to use the wrappers for:

Install the command line version of SignalP 3.0 and ensure signalp is on the PATH, see: http://www.cbs.dtu.dk/services/SignalP/ Install the command line version of TMHMM 2.0 and ensure tmhmm is on the PATH, see: http://www.cbs.dtu.dk/services/TMHMM/ Install the command line version of Promoter 2.0 and ensure promoter is on the PATH, see: http://www.cbs.dtu.dk/services/Promoter"

lecorguille commented 8 years ago

@bgruening Yes

bgruening commented 8 years ago

I'm very skeptical about the new SignalP version. We are not allowed to distribute it :( @Eduardo-Alves this also applies for Docker containers, so we can not ship a functional tool inside of this container. We can add documentation to include the binary manually into our container during runtime. But during build time this is not possible. The first solution is not user friendly at all so I would vote for not including this tool in this container :(

Eduardo-Alves commented 8 years ago

looking at alternatives. http://bmcbioinformatics.biomedcentral.com/articles/10.1186/1471-2105-10-S15-S2

Eduardo-Alves commented 8 years ago

I found a few alternatives: sigCleave is part of the emboss https://github.com/galaxyproject/tools-devteam/tree/master/tools/emboss_5 sigHMM (available for non-commercial use -- is this acceptable?) http://share.gene.com/share/zhang.wood.bioinformatics.2003/sighmm/index.html PredSi (no restrictions) http://www.predisi.de/

PredSi performs best of the three according to the link in my previous post.

Any experience with these software? I need to check if the output is compatible with trinotate.

bgruening commented 8 years ago

No experience so far. I would avoid all strange licenses like the one from sigHMM. But PredSi sounds nice ... thanks for the research!

Eduardo-Alves commented 8 years ago

i wrapped PredSi and uploaded to testtoolshed https://testtoolshed.g2.bx.psu.edu/view/eduardo/predsi/dda118a96cb0

bgruening commented 8 years ago

Nice this looks good! Do you want to put this into https://github.com/galaxyproject/tools-iuc. I can guide you through this process and help you creating conda dependencies.

Eduardo-Alves commented 8 years ago

Thank you Björn, please let me know how to do it

Eduardo

On Fri, Sep 30, 2016 at 4:32 PM, Björn Grüning notifications@github.com wrote:

Nice this looks good! Do you want to put this into https://github.com/ galaxyproject/tools-iuc. I can guide you through this process and help you creating conda dependencies.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/galaxy-genome-annotation/docker-galaxy-genome-annotation/issues/5#issuecomment-250775935, or mute the thread https://github.com/notifications/unsubscribe-auth/AJUvUZi3LnQV1gRWSZwIQZ-Xf5gMMlg9ks5qvSt-gaJpZM4JBwD5 .

bgruening commented 8 years ago

@Eduardo-Alves have a look at this example: https://github.com/galaxyproject/tools-iuc/pull/899

You more or less just need to create a PR against https://github.com/galaxyproject/tools-iuc I will review it and we can iterate until it is perfect :)

Thanks a lot! Bjoern

lecorguille commented 8 years ago

WIP Trinotate wrapper: https://github.com/galaxyproject/tools-iuc/pull/1030

Eduardo-Alves commented 7 years ago

Bjoern

I have moved predsi (signal peptide prediction )and two other tools (tmseg and dgpi) to my tools-iuc branch. they are under protein_annotation.

https://github.com/Eduardo-Alves/tools-iuc/tree/master/tools/protein_annotation https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_predsi_2004_02_13 https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_tmseg_2_2_0 https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_dgpi_2_04

I also created a tools, mergegffs which works similar to trinotate: It loads a protein prediction gff and several annotations: blast, tmhmm, signalp, hmmer to a sqlite database using gffutils as you suggested during GCC2016.

https://github.com/Eduardo-Alves/tools-iuc/tree/master/tools/mergegffs https://github.com/Eduardo-Alves/tools-iuc/tree/master/packages/package_genomegtftools_1_0 (this is a fork of the python package, I have the authors permission to wrap it and I will do a PR to his python repository with my changes)

The tools are working fine when installed from toolshed but I am getting an error in travis CL since it is using conda resolution only.

https://travis-ci.org/Eduardo-Alves/tools-iuc/jobs/219895680

UPDATE: I managed to test using shed_test. Found some issues with mergegffs and working on it.

planemo shed_test --shed_target local --owner planemo --no_cleanup --galaxy_root /opt/galaxy/galaxy-app --tool_dependency_dir /opt/galaxy/galaxy-app/database/dependencies

Thank you

Eduardo