Closed chapmanb closed 12 years ago
This also includes an addition to the POM to force maven to use a non-ancient Java version. With the default maven on Ubuntu it would strangely try and compile with 1.3, complaining about that version not supporting generics. I kept this a separate commit so you could cherry pick in case it breaks. My knowledge of maven is not strong.
Looks great, thanks very much for the pull request. I am especially excited about @JsonIgnoreProperties(ignoreUnknown=true) annotation, I think I will put that on all the beans. I was thinking the parsing was too strict and making blend4j overly tied on a specific "version" of Galaxy, ignoring all unknown properties would go along way toward mitigating that.
Also now that it is returning beans instead of a response object, I renamed showHistoryContentsRequest to showHistoryContents for consistency with the rest of the API. Sorry about that.
John; Thanks for the API fix. Apologies, I'm not very good at thinking and writing Java code at the same time. The ignoreUnknown is awesomely useful for some JSON like Datasets where there can be a ton of different metadata objects. I was about to cry thinking about all those getters and setters. Can you push the updates to your maven repo when you have a chance? Thanks again for getting this started, and for the git access.
The updated artifacts have been pushed out, my jenkins job to do that is not running automatically - I will need to look into that.
John; Thanks for starting this project, this is awesome. I added in some additional functionality for retrieving history details and datasets.
I'm exploring using this to push and puil from Galaxy histories and have a proof of concept library in Clojure that does the pull part:
https://github.com/chapmanb/clj-blend