galaxyproject / blend4j

blend4j is a JVM partial reimplementation of the Python library bioblend for interacting with Galaxy, CloudMan, and BioCloudCentral.
Eclipse Public License 1.0
16 stars 22 forks source link

Added ability to set to_ext when downloading dataset #30

Closed apetkau closed 9 years ago

apetkau commented 9 years ago

This fixes an issue when downloading datasets. Before this fix, the request sent was:

GET /api/histories/[history_id]/contents/[dataset_id]/display?key=[api key]

However, after this fix the request is:

GET /api/histories/[history_id]/contents/[dataset_id]/display?key=[api key]&to_ext=[extension]

This is, it adds on the to_ext parameter. This mimics the behaviour in bioblend https://github.com/galaxyproject/bioblend/blob/v0.5.3/bioblend/galaxy/datasets/__init__.py#L95.

jmchilton commented 9 years ago

Awesome, thanks for the fix.

apetkau commented 9 years ago

No problem.