Workflow Reports/Pages papercuts

[hexylena]

I've used pages "in anger" today, to try and make a report to share with my boss and encountered some paper cuts. None of these are fatal, but I think some of them would make the UX nicer if anyone has time.

Overall the pages experience with markdown editing is SO MUCH BETTER, that I'll continue to use it (especially once sharing/embedded pdfs are fixed), it's really such an incredible massive change that makes publishing reports so much nicer. Thank you everyone who worked on it! Now, on to to the complaint list :sweat_smile:

• [ ] Selecting an Image should filter on image types maybe? I.e. not list a bunch of hidden, tabular files?
• [ ] List tags in addition to filenames in selector
• [ ] Do not show hidden files in file selector (unless I check a box)
• [ ] Permit multi-selection of e.g images to embed
• [ ] Show me a preview not by closing the editor, but maybe save + pop up a preview in a modal window? That sounds nicer
• [ ] I would like <details><summary>... to work (I'd prefer that to linking.) https://github.com/galaxyproject/galaxy/issues/15088
  • [ ] Especially since a Link triggers a file download, when I just wanted them to be able to see a PNG.
• [x] "Link to dataset" could be improved by using the dataset name (and showing tags), rather than just the hashed ID. I gave them nice names on purpose. Ah you can use label, which I only discovered by grepping Galaxy's source code. Is there a way this could be exposed in the UI? Or maybe that it defaults to using the HDA name, rather than defaulting to the ID, making discovering this less important?
• [ ] can I not set the width of an image in a report?
• [ ] Per https://github.com/galaxyproject/galaxy/issues/15088 a ToC would be incredible, especially as the images are gigantic and it isn't clear there's more content.
• [ ] Embedding a PDF (e.g. heatmap) tool, produces a weirdly "short" embed, compared to e.g an image which is just full size
• [x] Embedding a "dataset" is different from an "embedded dataset", it wasn't clear why until I inspected the element and saw the Vue object had a URL including essetially "embed this as text" which wasn't what I wanted. Thus, the labels could use clarification that one is text-file only. Seems fixed in 22.05
• [ ] There appear to be two scroll bars for PDFs, making scrolling janky as hell.
• [ ] Table styling could be nicer
• [ ] Workflow invocation embed is a bit boring, some boxes could be swell.
• [ ] Sharing still renders making pages basically useless for my purposes.
  • [x] Workflow embed says "It's not shared with your user" (when logged out) Fixed in 22.05, yay!
  • [ ] PDF embeds don't work ("authentication issue", even if you share the object), but, funnily enough, can be downloaded via clicking their associated Download button.
  • [ ] Images are broken (unless you share the history)
  • 
• [x] Downloading a PDF triggers a url change/page load instead of forcing a file download.
• [ ] Pages exports are either very slow or temporarily non-functional specifically on eu on the test page linked, I've been waiting ~5 min.
• [ ] Also the requests are being sent every single second, maybe consider adding some backoff here, with an upper limit (e.g. 15 seconds), this feels like unnecessary server load we could do away with. Even if it's a small amount of load, polling multiple times per second just feels not optimal.

demo page available here: https://usegalaxy.eu/u/helena-rasche/p/test

The sharing really needs to trigger something recursive, looking at embedded objects, and asking the user "You've included this list of wfs/dataests/etc, and you're trying to share your page, would you like to also share all linked objects?" And I guess that needs to show a dialog every time they edit an already shared page to add a new item.

[hexylena]

The lack of sharing datasets is unfortunately making some of the smörgåsbord reviewing difficult, I can't see the datasets they reference. https://usegalaxy.eu/published/page?id=cd781148a714c5a6

[martenson]

Downloading a PDF triggers a url change/page load instead of forcing a file download.

Has been changed to "generate pdf" in https://github.com/galaxyproject/galaxy/pull/16209 and opens in a new tab. I find that more convenient for preview and the download is a button away. Is that satisfactory?

[hexylena]

Yes, absolutely @martenson ! I missed your PR, that's a fantastic improvement