search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.42k stars 1.01k forks source link

[EU] Advanced tool search vs basic search discrepancies #16268

Open hexylena opened 1 year ago

hexylena commented 1 year ago

Seen on EU running 23.0, neither org nor (dev) AU experience the issue

The advanced search for the 'name=circos' returns all of the tools in the circos suite except for circos itself. Compare with the default search which returns circos as it's top hit. The name of that tool is just 'circos', so I've tried circo and circ which still return all of the tools in the suite, but not the main tool that people will search for.

image

Searching by ID also has the same issue: https://usegalaxy.eu/tools/list?id=%2acircos%2a

And searching by the precise tool ID returns nothing, with or without the +galaxy12

image

https://usegalaxy.eu/tools/list?id=toolshed.g2.bx.psu.edu%2Frepos%2Fiuc%2Fcircos%2Fcircos%2F0.69.8%2Bgalaxy12 https://usegalaxy.eu/tools/list?id=toolshed.g2.bx.psu.edu%2Frepos%2Fiuc%2Fcircos%2Fcircos%2F0.69.8

ElectronicBlueberry commented 1 year ago

When looking into this, I noticed the missing Circos tool having hidden set to true, unlike the other Circos tools, which have it set to an empty string. Could this be related to the issue?

hexylena commented 1 year ago

That seems very plausible

<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/014a21767ac4/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy1" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/184dfd9e113d/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy3" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/290a11559985/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy10">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/31a35811dda6/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy9" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/4b519282a05b/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy6" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/740057a5126d/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy5" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/7f13dc906cb9/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy8" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/a64dc31ab7f2/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy4" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/c4bde687c846/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy12">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/e6cbe3190642/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy7" hidden="true">
<tool file="toolshed.g2.bx.psu.edu/repos/iuc/circos/fd59d783248a/circos/circos.xml" guid="toolshed.g2.bx.psu.edu/repos/iuc/circos/circos/0.69.8+galaxy2" hidden="true">
ElectronicBlueberry commented 1 year ago

It also looks like +galaxy9 is being treated as the newest version. It's the version being loaded into the tool form when accessing Circos, even though the url states &version=0.69.8 galaxy12

nsoranzo commented 1 year ago

@ElectronicBlueberry That's https://github.com/galaxyproject/galaxy/pull/13570 and related issues, on my todo list.

bgruening commented 1 year ago

Not sure if this helps but I added hidden to not have the sorting issue. We had many peoples that were using +9 and not the latest version. So I thought hiding all <=+9 tools will help.

ElectronicBlueberry commented 1 year ago

My guess is that the wrongly detected newest version 9 being hidden is causing this. If this is the case, fixing the sorting should fix the search. We could test this by removing hidden from version 9, and seeing if that fixes the search.

bgruening commented 1 year ago

I did so and restarted the handlers, please check in 10min.

ElectronicBlueberry commented 1 year ago

@bgruening it worked

bgruening commented 1 year ago

Mh, should the sort haben after the filter/hidden?

hexylena commented 1 year ago

I guess we should just do https://github.com/galaxyproject/galaxy/pull/13570, and not worry about the hiding. it is such a rare case where we want to partially hide tools like that