search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.42k stars 1.01k forks source link

Job submission Failure" popup when the use of MetadataElement in biom1 datatype #2137

Open mariabernard opened 8 years ago

mariabernard commented 8 years ago

Hi, we developed tools that generate biom1 output file. But since the use of MetadataElement in the biom class in text.py (#1198 , commit b5c77a8e8c0255f61ca62a7ff2311d443e224bec ) , when executing a job, a "Job submission Failure" pop up appear even if the job is running successfully (after refresh the history). I am searching from where it may come but if you have some ideas, I would be very interested in?

regards

Maria

mariabernard commented 8 years ago

Hi,

To be more precised, the error message is "Attempted to encode None id". I modify the class Biom1 in lib/galaxy/datatypes/text.py line 141 and more precisely the default value for table_id: MetadataElement( name="table_id", default=None, desc="table_id", param=MetadataParameter, readonly=True, visible=True, optional=True, novalue=None ) by MetadataElement( name="table_id", default="ID", desc="table_id", param=MetadataParameter, readonly=True, visible=True, optional=True, no_value=None )

I test different default value None, "" and "ID" in different condition, but only "ID" solves the problem (which is strange).

...... to be continued .....

Maria

blankenberg commented 8 years ago

Hi @mariabernard I've encountered this problem as well, and have diagnosed the root cause of the problem here: https://github.com/galaxyproject/galaxy/issues/2423. Hopefully we will have a quick resolution.

Thanks for reporting this issue!