search

galaxyproject / galaxy

Data intensive science for everyone.
https://galaxyproject.org
Other
1.42k stars 1.01k forks source link

on_string for collections selected in `multiple=true` inputs #7467

Open bernt-matthias opened 5 years ago

bernt-matthias commented 5 years ago

If a collection is chosen in a multiple=true input field the on_string for generated data sets is different to the case if input is a collection. Reminds me on https://github.com/galaxyproject/galaxy/issues/7392

I think it should be tool name on collection xyz in both cases. instead of ... on data a and data b...

bernt-matthias commented 5 years ago

At least documented/discussed now in the docs now: https://github.com/galaxyproject/planemo/pull/930

mvdbeek commented 5 years ago

This is fixable (_get_on_text in https://github.com/galaxyproject/galaxy/blob/0b8dec5af0cd75489cb76f96295c5c2f90ead52f/lib/galaxy/tools/actions/__init__.py#L292 would just also need to look at inp_dataset_collection), but I'm hoping we can get rid of the reference to hids (=data N ) altogether. If no explicit name is set we could just compute that string on the fly since we know the input datasets and we know the tool that was used to produce the dataset. If we did that the references would remain intact even if copied to a different history.

bernt-matthias commented 5 years ago

This would be great.