galaxyproteomics / tools-galaxyp

Galaxy Tool Shed repositories maintained and developed by the GalaxyP community
MIT License
34 stars 58 forks source link

move "convert windows newlines" tool into an other place #9

Open bgruening opened 9 years ago

bgruening commented 9 years ago

This tool looks strange to me. If the purpose of this tool is to convert windows newlines only for ProteinPilot, as the name suggest, we should include the tr magic into the wrapper of ProteinPilot.

If such a tool is really missing in general we should put it into a text-manipluation repository, e.g. here: https://github.com/bgruening/galaxytools/tree/master/text_processing/text_processing

Anyone know if this is still a problem or does Galaxy take care of this? @jmchilton @jj-umn ?

jmchilton commented 9 years ago

Ugh... I don't remember why it is a separate tool. I imagine group2xml used to produce tabular files outputs them with windows newlines - Galaxy will fix uploads but not tabular files created by other tools - but I a not sure why I didn't "fix" them in the tool. Hmm... the folks at MSI may be able to look at the workflows and determine if this needs to be a tool or not still.