search

gallandarakhneorg / afc

Arakhnê Foundation Classes
http://www.arakhne.org/afc/
Apache License 2.0
14 stars 8 forks source link

Update OrientedPoint2D hierarchy. #145

Closed tpiotrow closed 8 years ago

tpiotrow commented 8 years ago

Since OrientedPoint2D is more of a Point2D than a Shape2D, it is more logical to change the inheritance hierarchy.

This PR also introduce SegmentPoint, which are segments defined by their extremities.

gallandarakhneorg commented 8 years ago

Your contribution is very interesting.

I propose to replace the code of Segment2[di]fx by SegmentPoint[di]fx. In other words, all the fx shapes will not more has "primitive" properties, but "point" properties. The public interface of those shapes will remain unchanged.

@tpiotrow, @olivierlamotte, @ngaud, what do you think about this change in the FX API of AFC?

tpiotrow commented 8 years ago

Agreed.

gallandarakhneorg commented 8 years ago

Contributes to #47.

This PR is merged prior to any change implied by the discussion above.