search

galsci / mapsims

Map based simulations software for CMB Experiments
BSD 2-Clause "Simplified" License
3 stars 1 forks source link

Modifications to mapsims for new SO noise simulation #58

Closed zonca closed 4 years ago

zonca commented 4 years ago

Will be tagged 2.3.0

Simulation files: https://github.com/simonsobs/map_based_simulations/pull/33

msyriac commented 4 years ago

This seems to break the atmosphere=False case, since fsky is not defined in Line 738 of noise.py.

msyriac commented 4 years ago

Please fix the double "pixell.enmap" here: https://github.com/zonca/mapsims/blob/bf397268adafa85b5e25cd701f5291f56174d576/mapsims/noise.py#L752 It should be pixell.enmap.enmap, not pixell.enmap.pixell.enmap

msyriac commented 4 years ago

The self.pmap in https://github.com/zonca/mapsims/blob/bf397268adafa85b5e25cd701f5291f56174d576/mapsims/noise.py#L565 should be self.pixarea_map

zonca commented 4 years ago

@msyriac merged it, can you fix doing another PR?