gama-platform / gama.old

Main repository for developing the 1.x versions of GAMA
GNU General Public License v3.0
304 stars 99 forks source link

svn shared models not working anymore #709

Closed pcaillou closed 9 years ago

pcaillou commented 9 years ago
What steps will reproduce the problem?
1.Before it was possible to upload share model form a dedicated svn (shared_model)
direclty from GAMA
2.It was doable by clicking on "Shared Models" -> Update Shared Models
3.

What is the expected output? What do you see instead?
This is not working anymore. and it shoes a pop up menu "problem occured"

Please use labels and text to provide additional information.

Original issue reported on code.google.com by agrignard on 2013-11-06 04:57:50

pcaillou commented 9 years ago
Can you be a little bit more explicit ? 

Which version of GAMA does it affect ?

Is it the upload or the download that does not work ? 

Do you have any log to provide ? 

Thanks.

Original issue reported on code.google.com by alexis.drogoul on 2013-11-06 06:50:28

pcaillou commented 9 years ago
We are facing this issue with all the gama 1.6 (with the 6 EDSS master student wotking
on mac and windows).

The upload is not working (as if the svn plugin was not available in the binary)

I try to send a screenshot of the pop-up soon.

Original issue reported on code.google.com by agrignard on 2013-11-06 07:32:53

pcaillou commented 9 years ago
Sorry I wan meaning the download of a model.

This is a screenshot form a windows version with the pop-up window

Original issue reported on code.google.com by agrignard on 2013-11-07 02:33:55


pcaillou commented 9 years ago
Well, I've figured out the problem. The SVN access in GAMA requires both the high-level
infrastructure built in Eclipse (provided by org.polarion.eclipse.team.svn.connector.svnkit17)
and the core SVN operations found in SVNKit.jar (for getting the html description of
projects, etc.).  While the former includes SVNKit.jar, it does not reexport it (i.e.
the core library is inside the plugin, but the plugin prevents access to it, which
is somewhat stupid). 
Three options can then be thought of:
1) Include a duplicate copy of SVNKit.jar in msi.gama.ext. It is already the case in
the SVN version, but I probably forgot to include it into the build path as well, which
means this library is not present in the release version. This is however a workaround,
which makes us lose 2MB, and may generate errors if the two versions are not strictly
compatible.

2) Rewrite all the SVN accesses in GAMA to only use the high-level methods provided
in  org.polarion.eclipse.team.svn.connector.svnkit17 . This would be the cleanest way
to proceed with, but requires some time… And maybe some changes too to the way we handle
shared projects.

3) Include the connector, in a modified version, directly into msi.gama.core, effectively
copying the source code and plugin definitions there (and put the required libraries
into msi.gama.ext, minus SVNKit.jar). This is a possible option, but not completely
clean and which could prevent benefiting from further bug fixes made by Polarion.

I still have to figure out which option is the best. In the meantime, a workaround
consists in downloading the version of svnkit.jar I've attached to this comment and
copying it into the directory Gama>plugins>msi.gama.ext .

Original issue reported on code.google.com by alexis.drogoul on 2013-11-13 05:05:27


pcaillou commented 9 years ago
This issue was closed by revision r8126.

Original issue reported on code.google.com by alexis.drogoul on 2013-11-13 18:24:49