search

gammapy / gamma-cat

An open data collection and source catalog for gamma-ray astronomy
https://gamma-cat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 17 forks source link

Follow up of renaming #199

Closed pdeiml closed 6 years ago

pdeiml commented 6 years ago

I fixed the problem described at the end of https://github.com/gammapy/gamma-cat/issues/171

Additionally, I executed make.py all which lead to a update in the output folder.

cdeil commented 6 years ago

Ah yes, I forgot to finish the update for the webpage and check if it works. That commit looks good to me.

The other one, where you update the output folder, looks just like you have different floating point formatting and that is not something that should be committed. Please remove that commit here, and update locally to Numpy 1.14, then you should get the same output that I committed earlier today.

pdeiml commented 6 years ago

Ok, removed the update output commit.

RTM

cdeil commented 6 years ago

Looks good. I didn't test locally. Merging now.