Open pdeiml opened 6 years ago
I would stronly prefer to only have one single config file for the catalog.
I.e. my suggestion would be to change this file
https://github.com/gammapy/gamma-cat/blob/master/input/gammacat/gamma_cat_dataset.yaml
to add the extra info, e.g. a sed_ref_id
key.
Ok, if we stay with one single file, then I would suggest to add three additional infos: sed_ref_id lc_ref_id ds_ref_id (data set)
What do you think?
I would leave reference_id
as-is, and optionally if there is reference_id_sed
or reference_id_lc
, use that for SED or LC (and otherwise default to use the same for all).
I.e. minimal edits to get what we want.
But either way, your more verbose, but also more explicit choice for each part of the catalog data is also good.
This is one way how to control which SED goes to the catalog.
If you look to input/gammacat/gamma_cat_sed.yaml and there at source_id = 1, you can see the idea:
I only want to introduce this idea of a schema and if it is agreed then one needs to add the keywords to all sources.