search

gap-packages / forms

Forms -- sesquilinear and quadratic, a package for GAP
https://gap-packages.github.io/forms
2 stars 3 forks source link

tst/basechange.tst: ensure base changes yield canonical forms #66

Closed fingolfin closed 8 months ago

fingolfin commented 8 months ago

The new tests (still) don't pass, due to bugs in the code -- but those are not recent, they've been present since at least forms version 1.2.2 shipped in GAP 4.5.7.

See issues #58 and #65.

UPDATE: the bug in the symplectic case wasn't hard to find and fix, so this PR now fixes #58

UPDATE 2: issue #65 turned out to be an issue in the documentation, not the code; I've adjusted the test and they now pass!

codecov[bot] commented 8 months ago

Codecov Report

Merging #66 (d7af220) into master (dc34bfb) will increase coverage by 1.71%. Report is 10 commits behind head on master. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #66 +/- ## ========================================== + Coverage 82.35% 84.07% +1.71% ========================================== Files 5 5 Lines 3475 3466 -9 ========================================== + Hits 2862 2914 +52 + Misses 613 552 -61 ``` | [Files](https://app.codecov.io/gh/gap-packages/forms/pull/66?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages) | Coverage Δ | | |---|---|---| | [lib/forms.gi](https://app.codecov.io/gh/gap-packages/forms/pull/66?src=pr&el=tree&filepath=lib%2Fforms.gi&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages#diff-bGliL2Zvcm1zLmdp) | `79.54% <100.00%> (-0.72%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/gap-packages/forms/pull/66/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gap-packages)